[haiku-commits] Re: r38765 - haiku/trunk/src/apps/mediaplayer/interface
- From: "Stephan Assmus" <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 23 Sep 2010 12:28:16 +0200
Hi Axel,
Von: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
> "Stephan Assmus" <superstippi@xxxxxx> wrote:
> > Von: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
> > > Ah, what exactly did you improve? I did not even notice that the
> > > volume
> > > slider snaps at all, and I think it's a bit too subtle (but that's
> > > probably only because of the missing feedback).
> > The snapping is based on mouse travel distance in my code, not on the
> > slider values. So it's actually more consistently noticeable in my
> > version...
>
> Ah, that makes sense! I've improved desklink's version in r38797, but
> it will enlarge the snap range with a larger slider.
Nice, I should have done as much... sorry about that. The enlarging of the
snapping range is not a problem in my version, is it?
> > > Not that I know of; at least it seems to work nicely when using the
> > > master volume (and for other stuff as well). I don't know how the
> > > media
> > > player controls its volume, but it seems to be independent from its
> > > output node for whatever reason.
> > > Also, I like the linear dB volume slider a lot more than what VLC
> > > and
> > > the MediaPlayer are currently doing.
> > When I tried it last time, the slider did not pick up changes live
> > when
> > modifying the volume via the Media preflet. That was basically the
> > main
> > reason why I didn't put more energy into making this a proper
> > solution.
>
> I just checked it again, and indeed it sometimes does not work, but
> most of the time it does. It always works if you move the slider in the
> Media preferences first once; shouldn't be too hard to find out :-)
>
> > However the slider on the desktop never updated in my tests.
>
> This one actually always works for me; only the slider in the media
> prefs sometimes doesn't. Maybe there is more to it.
If you want to have a look, I'd be glad. I am stuck trying to get seeking in
some streams to work more reliably...
Best regards,
-Stephan
Other related posts:
