[haiku-commits] Re: r38552 - haiku/trunk/src/add-ons/kernel/bus_managers/ata

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 19 Sep 2010 13:03:17 +0200

korli@xxxxxxxxxxxxxxxx wrote:
> Log:
> Only swap words on little endian machines. Checked against FreeBSD.
[...]
> -             *word = (*word << 8) | (*word >> 8);
> +             *word = B_BENDIAN_TO_HOST_INT16(*word);

That seems to be the wrong place for this, though; the whole loop is 
superfluous depending on the endian.

Bye,
   Axel.


Other related posts: