[haiku-commits] Re: r38472 - in haiku/trunk: headers/private/kernel/boot/net src/system/boot/loader/net
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 24 Sep 2010 15:26:43 +0200
Andreas Färber <andreas.faerber@xxxxxx> wrote:
> Am 31.08.2010 um 09:07 schrieb Axel Dörfler:
> > andreas.faerber@xxxxxx wrote:
> >> Some corner cases like wrapping sequence numbers may cause a
> > > timeout.
> > src/add-ons/kernel/network/protocols/tcp/tcp.h contains a nice and
> > simple tcp_sequence C++ implementation that you may want to reuse.
> There seemed to be zero reuse apart from remote disk. Will check,
> thanks for the hint!
Not sure what you mean by that.
> > Since TCP has limited use, can you please make it optional, that is
> > add the possibility to not compile it in via defines when it's not
> > wanted?
> > I could imagine that we will only enable it for certain platforms
> > and
> > uses.
> There is no prior art there, and I don't see why TCP would have less
> use than UDP.
UDP is at least used by our very own network boot implementation :-)
But in general, you are right, of course - furthermore, the whole boot
network stack should be optional.
> It's not just about compiling them in but also about NetStack
> initialization.
> What I could come up with was making TCP.cpp conditional on $
> (TARGET_ARCH) = ppc in the Jamfile and using #ifdef __POWERPC__ in
> NetStack.cpp; that would work for me, but I don't consider it a good
> move. Do you have a more general suggestion we could apply to UDP,
> too?
Yes, have a look at how it's done for file systems in
src/system/boot/loader/Jamfile, and partitions.cpp.
Bye,
Axel.
Other related posts:
