[haiku-commits] Re: r37670 - in haiku/trunk: build/jam headers/os/drivers headers/private/graphics/matrox headers/private/graphics/neomagic src/add-ons/accelerants/ati ...
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 22 Jul 2010 22:33:21 +0200
Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote:
> 2010/7/22 Grzegorz Dąbrowski <grzegorz.dabrowski@xxxxxxxxx>:
> >>> +++ haiku/trunk/src/add-
> > > > ons/kernel/bus_managers/firewire/firewire.c
> >>> 2010-07-21 21:43:20 UTC (rev 37670)
> >>> @@ -1096,7 +1096,6 @@
> >>> fw_tl2xfer(struct firewire_comm *fc, int node, int tlabel, int
> > > > tcode)
> >>> {
> >>> struct fw_xfer *xfer;
> >>> - int s = splfw();
> >>> int req;
> >> I looked it up specifically, and splfw() doesn't have any function
> >> anymore.
> > I wonder, if splx(s) should be called instead of remove splfw.
> Please note this code is ported from FreeBSD, so this fix can render
> the synchronisation work more difficult in my opinion.
That's why I looked it up; even in FreeBSD, this function just resolves
to a "return 0;" nowadays. I have no idea why they don't simply clean
up their sources.
Bye,
Axel.
Other related posts:
