[haiku-commits] Re: r36112 - haiku/trunk/src/add-ons/print/transports/ipp

Hi Ithamar,

2010/4/10  <ithamar.adema@xxxxxxxxxxxxxxxx>:

> +IPPPrinterRoster::~IPPPrinterRoster()
> +{
> +       if (fEndpt)
> +               delete fEndpt;
> +}

It might be a good idea to ask the IPPListener thread to quit before
deleting the endpoint.

> +
> +       while((len=fEndpt->ReceiveFrom(packet, sizeof(packet) -1, 
> srcAddress)) > 0) {

> +
> +       while(*pos && *pos != '"')
> +               outStr.Append(*pos++, 1);

> +       while(*pos && isspace(*pos))
> +               ++pos;

> +IPPPrinterRoster::parseString(BString& outStr, char*& pos)
> +IPPPrinterRoster::ippListeningThread(void *cookie)

The coding style requires a blank between while and the left
parenthesis, a capitalized method name. Private methods are also
prefixed with an underscore.

> Modified: haiku/trunk/src/add-ons/print/transports/ipp/Jamfile
> -       : be $(TARGET_NETWORK_LIBS) $(TARGET_LIBSTDC++)
> +       : libshared.a be bnetapi $(TARGET_NETWORK_LIBS) $(TARGET_LIBSTDC++)
>  ;

bnetapi should be $(TARGET_NETAPI_LIB)

Good to see you committing :)

Bye,
Jérôme

Other related posts: