[haiku-commits] Re: r35439 - in haiku/trunk: data/catalogs/apps data/catalogs/apps/aboutsystem src/apps/aboutsystem

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 10 Feb 2010 15:45:24 +0100

On 2010-02-09 at 13:35:32 [+0100], aljen-mlists@xxxxx wrote:
> Author: aljen
> Date: 2010-02-09 13:35:31 +0100 (Tue, 09 Feb 2010)
> New Revision: 35439
> Changeset: http://dev.haiku-os.org/changeset/35439/haiku

Hi Arthur,

>  class AboutApp : public BApplication {
>  public:
> -                                AboutApp();
> +                    AboutApp();
> +private:
> +        BCatalog        fCatalog;
>  };
>  
> +
>  class AboutWindow : public BWindow {
>  public:
> -                            AboutWindow();
> +                    AboutWindow();
>  
>      virtual    bool            QuitRequested();
>  };
>  
> +
>  class LogoView : public BView {
>  public:
> -                            LogoView();
> -    virtual                    ~LogoView();
> +                    LogoView();
> +    virtual                ~LogoView();
>  
>      virtual    BSize            MinSize();
>      virtual    BSize            MaxSize();
> @@ -91,14 +99,16 @@
>      virtual void            Draw(BRect updateRect);
>  
>  private:
> -            BBitmap*        fLogo;
> +            BBitmap*    fLogo;
>  };

Please do not change the indentation of headers like that. The version before 
was correct. I saw you do this in an earlier commit as well, please revert 
those indentation changes. Nice patches, otherwise!

Best regards,
-Stephan

Other related posts: