[haiku-commits] Re: r35104 - in haiku/trunk: build/jam data/system/boot src/apps/text_search src/system/kernel/fs src/system/libroot/os ...
- From: Stephan Assmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 19 Jan 2010 19:31:06 +0100
On 2010-01-19 at 19:14:28 [+0100], Urias McCullough <umccullough@xxxxxxxxx>
wrote:
> On Sun, Jan 17, 2010 at 2:51 AM, Stephan Assmus <superstippi@xxxxxx>
> wrote:
> > On 2010-01-17 at 11:42:38 [+0100], Axel Dörfler
> > <axeld@xxxxxxxxxxxxxxxx> wrote:
> >> What about it?
> >> Only references to /boot/var and /boot/var/tmp had to be changed.
> >
> > Yep. It skips this directory when copying an installation. See
> > CopyEngine::_ShouldCopyEntry(). It's a bit hidden, but would not impose
> > a huge speed penalty like it could be implemented.
>
> This one did bite me last night while installing from a partition running
> latest rev to a USB stick - it proceeded to copy the swap file to the USB
> stick :(
>
> Looks like the current implementation is somewhat as it seems to only
> look for a couple directories one level below the root of a given volume.
>
> FWIW, I also think it should maybe retain both the old and new paths in
> case someone wishes to use the newer installer to install from an older
> Haiku volume, but that's just me since I tend to maintain and copy
> multiple partitions with different revs of Haiku on them around.
Good points. I already forgot about this problem, but I'll try to fix it
ASAP. Although I think it's not good manners to go about changing something
without pressing need and then not making sure it works as good before,
even though the culprit is code that wasn't written nicely to begin with.
;-)
Best regards,
-Stephan
Other related posts:
