[haiku-commits] Re: haiku: hrev50241 - src/kits/media headers/private/media headers/os/media

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 2 May 2016 16:19:02 +0200

Am 02.05.2016 um 12:47 schrieb Dario Casalinuovo:

I might be in favor of putting it in private API, but how do you suggest
to solve then the shutdown_media_server notifications problem without
something like SyncToServer?

Sorry, that's not my ROI right now: what exactly is the problem with shutdown_media_server notifications?

> Anybody could restart the server before, too, what's launch_daemon
> specific about this? And what's the deal, anyway? Where is the
> difference when you call launch_media_server() manually?
Is this really a question? I'm surprised how you express things to be
obvious but don't understand the meaning of that? launch_daemon is
obviously the major and most probable of messing with the restart
service, but not the only. Since the introduction of the launch_daemon

I mean that the launch_daemon does not create problems, it may just make previously existing problems more obvious. So if you fix something there, it's not a launch_daemon specific fix, it's a general fix.

> I'm not sure we need a launch_media_server anymore.

Yes, it's probably not really needed anymore, however, we still need it for binary compatibility. We could probably change its implementation to a:
BLaunchRoster().Start("x-vnd.Haiku-media_server");

Note that you can disable the media_server service from the launch_daemon and then still launch it manually. That's why the above implementation would actually make sense -- plus the launch_daemon will then monitor the team, and restart it when needed.

Bye,
   Axel.

Other related posts: