[haiku-commits] Re: haiku: hrev48748 - src/servers/app/decorator
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 30 Jan 2015 08:34:15 +0100
Am 29/01/2015 um 22:40 schrieb jscipione@xxxxxxxxx:
4ac21cd37da3: Issue 11111 - Division by zero in TabDecorator
The patch does not solve or change the issue at all.
+++ b/src/servers/app/decorator/TabDecorator.cpp
@@ -406,13 +406,17 @@ TabDecorator::_DoTabLayout()
void
TabDecorator::_DistributeTabSize(float delta)
{
- ASSERT(CountTabs() > 1);
+ int32 tabCount = fTabList.CountItems();
+ ASSERT(tabCount > 1);
float maxTabSize = 0;
float secMaxTabSize = 0;
int32 nTabsWithMaxSize = 0;
- for (int32 i = 0; i < fTabList.CountItems(); i++) {
+ for (int32 i = 0; i < tabCount; i++) {
Decorator::Tab* tab = fTabList.ItemAt(i);
+ if (tab == NULL)
+ continue;
Why check for tab == NULL here? What problem should this solve?
Bye,
Axel.
Other related posts:
