[haiku-commits] Re: haiku: hrev48711 - src/servers/app/drawing

  • From: Rene Gollent <anevilyak@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 23 Jan 2015 07:57:59 -0500

On Fri, Jan 23, 2015 at 7:46 AM,  <pulkomandy@xxxxxxxxxxxxx> wrote:
>                         color_space                     fColorSpace;
>                         BitmapHWInterface*      fHWInterface;
> -                       UtilityBitmap*          fBitmap;
> +                       BReference<UtilityBitmap> fBitmap;
>                         BRegion                         fClipping;
>  };
>
>
>

I should further note, is fBitmap always assigned a reference to an
already existing UtilityBitmap? I see no adjustments in this commit to
the places where its value is assigned, so if it's ever the case that
said assignment is a freshly created one via operator=, you're
potentially leaking a reference here.

Regards,

Rene

Other related posts: