[haiku-commits] Re: haiku: hrev48705 - src/kits/network src/kits/network/libnetapi headers/os/net src/servers/net src/bin/network/ifconfig
- From: Adrien Destugues <pulkomandy@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 21 Jan 2015 13:02:30 +0100
On Wed, Jan 21, 2015 at 12:24:16PM +0100, Axel Dörfler wrote:
> Am 21.01.2015 um 10:05 schrieb pulkomandy@xxxxxxxxxxxxx:
> >* BNetworkInterfaceAddress is moved to libnetwork. It is modified to
> >not use BNetworkAddress (which is in libbnetapi) and instead use
> >sockaddr and sockaddr_storage directly. All callers are adjusted to
> >this. * Some support code is shared between BNetworkInterface and
> >BNetworkInterfaceAddress, move it to libnetwork but in the BPrivate
> >namespace.
>
> That's not really how I envisioned it, and, I think this is a rather
> messy solution.
> BNetworkInterfaceAddress should not be in libnetwork.so; does it really have
> that many advantages to use it within getifaddrs() over using the socket API
> directly?
BNetworkInterfaceAddress is exactly how I would implement that. I can
make a private class with exactly the same API and then make
BNetworkInterfaceAddress a wrapper around it, but I'm not sure what's
the point of doing that?
--
Adrien.
Other related posts:
