[haiku-commits] haiku: hrev48688 - src/servers/app/decorator

From: pulkomandy@xxxxxxxxxxxxx
To: haiku-commits@xxxxxxxxxxxxx
Date: Fri, 16 Jan 2015 18:44:45 +0100 (CET)
hrev48688 adds 1 changeset to branch 'master'
old head: bccd0cd661d182d81ccdc2e567baf7e544c89251
new head: 0bc1fc98a5f3cd1dd149cdb9ad30b826a4b54cbf
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=0bc1fc98a5f3+%5Ebccd0cd661d1

----------------------------------------------------------------------------

0bc1fc98a5f3: TabDecorator: Invalidate all tabs when updating a title
  
  Signed-off-by: Adrien Destugues <pulkomandy@xxxxxxxxx>
  
  Fixes #8569
  
  I'm not sure if this works properly if you reorder tabs (see #9175). But
  the fix for that is reordering the tab list to match the visible order,
  which doesn't affect this part of the code.

                                      [ Puck Meerburg <puck@xxxxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev48688
Commit:      0bc1fc98a5f3cd1dd149cdb9ad30b826a4b54cbf
URL:         http://cgit.haiku-os.org/haiku/commit/?id=0bc1fc98a5f3
Author:      Puck Meerburg <puck@xxxxxxxxxxxxx>
Date:        Fri Jan 16 17:30:29 2015 UTC
Committer:   Adrien Destugues <pulkomandy@xxxxxxxxx>
Commit-Date: Fri Jan 16 17:45:02 2015 UTC

Ticket:      https://dev.haiku-os.org/ticket/8569
Ticket:      https://dev.haiku-os.org/ticket/9175

----------------------------------------------------------------------------

1 file changed, 4 insertions(+), 2 deletions(-)
src/servers/app/decorator/TabDecorator.cpp | 6 ++++--

----------------------------------------------------------------------------

diff --git a/src/servers/app/decorator/TabDecorator.cpp 
b/src/servers/app/decorator/TabDecorator.cpp
index d7c3289..0d295a0 100644
--- a/src/servers/app/decorator/TabDecorator.cpp
+++ b/src/servers/app/decorator/TabDecorator.cpp
@@ -465,14 +465,16 @@ TabDecorator::_SetTitle(Decorator::Tab* tab, const char* 
string,
 {
        // TODO: we could be much smarter about the update region
 
-       BRect rect = TabRect(tab);
+       BRect rect = TabRect((int32) 0) | TabRect(CountTabs() - 1);
+               // Get a rect of all the tabs
 
        _DoLayout();
 
        if (updateRegion == NULL)
                return;
 
-       rect = rect | TabRect(tab);
+       rect = rect | TabRect(CountTabs() - 1);
+               // Update the rect to guarantee it updates all the tabs
 
        rect.bottom++;
                // the border will look differently when the title is adjacent
[haiku-commits] haiku: hrev48688 - src/servers/app/decorator

Other related posts:
