[haiku-commits] Re: haiku: hrev48666 - in src: system/kernel system/kernel/fs system/kernel/device_manager add-ons/kernel/file_systems/ext2
- From: Jérôme Duval <jerome.duval@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 13 Jan 2015 21:27:56 +0100
2015-01-12 18:23 GMT+01:00 <pulkomandy@xxxxxxxxxxxxx>:
> ############################################################################
>
> Revision: hrev48666
> Commit: 63fdcb8e7e09f975bd53e7fc18bc9ff3cfe1294c
> URL: http://cgit.haiku-os.org/haiku/commit/?id=63fdcb8
> Author: Adrien Destugues <pulkomandy@xxxxxxxxx>
> Date: Mon Jan 12 17:20:22 2015 UTC
>
> ext2: migrate to BOpenHashTable.
>
> ----------------------------------------------------------------------------
>
@@ -92,24 +87,24 @@ HashRevokeManager::Insert(uint32 block, uint32 commitID)
> status_t
> HashRevokeManager::Remove(uint32 block)
> {
> - RevokeElement* element = (RevokeElement*)hash_lookup(fHash, &block);
> + RevokeElement* element = fHash->Lookup(block);
>
> if (element == NULL)
> return B_ERROR; // TODO: Perhaps we should just ignore?
>
> - status_t retValue = hash_remove(fHash, element);
> + bool retValue = fHash->Remove(element);
>
> - if (retValue == B_OK)
> + if (retValue)
> delete element;
>
> - return retValue;
> + return B_ERROR;
> }
This isn't correct.
Bye,
Jérôme
Other related posts:
