hrev48525 adds 1 changeset to branch 'master' old head: 82e1194224df1dff49bdf46dd7150d24f8437ba3 new head: 57f933d348110f9db38bb7c7336a017147d4d100 overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=57f933d+%5E82e1194 ---------------------------------------------------------------------------- 57f933d: CID603224: missing break in parsedate. Could lead to wrongly setting the TYPE_MINUTE flag for an invalid (>59) number of minutes. Harmless, as that flag is never used. For completeness, also set the flag for seconds (also never used). Fixes #11552. [ Adrien Destugues <pulkomandy@xxxxxxxxx> ] ---------------------------------------------------------------------------- Revision: hrev48525 Commit: 57f933d348110f9db38bb7c7336a017147d4d100 URL: http://cgit.haiku-os.org/haiku/commit/?id=57f933d Author: Adrien Destugues <pulkomandy@xxxxxxxxx> Date: Thu Dec 18 14:50:39 2014 UTC Ticket: https://dev.haiku-os.org/ticket/11552 ---------------------------------------------------------------------------- 1 file changed, 5 insertions(+) src/system/libroot/os/parsedate.cpp | 5 +++++ ---------------------------------------------------------------------------- diff --git a/src/system/libroot/os/parsedate.cpp b/src/system/libroot/os/parsedate.cpp index c5c24c6..7c9f1c7 100644 --- a/src/system/libroot/os/parsedate.cpp +++ b/src/system/libroot/os/parsedate.cpp @@ -1014,11 +1014,16 @@ parsedate_etc(const char* dateString, time_t now, int* _flags) dateMask.Set(TYPE_HOUR); break; case 'M': + if (element->value > 59) + goto next_format; + dateMask.Set(TYPE_MINUTE); + break; case 'S': if (element->value > 59) goto next_format; + dateMask.Set(TYPE_SECOND); break; case 'y': case 'Y':