[haiku-commits] Re: haiku: hrev45278 - src/apps/terminal

  • From: Oliver Tappe <zooey@xxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 13 Feb 2013 14:40:47 +0100

Hi Siarzhuk,

On 2013-02-13 at 12:21:42 [+0100], zharik@xxxxxx wrote:
> hrev45278 adds 1 changeset to branch 'master'
> old head: 8940ad259ab803eff8176766a73f8f531142c3b6
> new head: a5b3caa295edb4064e3a560bced06ec27770c498
> overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=a5b3caa+%5E8940ad2
> 
[ ... ]
> diff --git a/src/apps/terminal/TermWindow.cpp 
> b/src/apps/terminal/TermWindow.cpp
> index cd2701f..239201d 100644
> --- a/src/apps/terminal/TermWindow.cpp
> +++ b/src/apps/terminal/TermWindow.cpp
> @@ -465,7 +465,7 @@ TermWindow::_SetupMenu()
>  
>      BLayoutBuilder::Menu<>(fMenuBar = new BMenuBar(Bounds(), "mbar"))
>          // Terminal
> -        .AddMenu(B_TRANSLATE_SYSTEM_NAME("Terminal"))
> +        .AddMenu(B_TRANSLATE("Terminal"))
>              .AddItem(B_TRANSLATE("Switch Terminals"), MENU_SWITCH_TERM, 
>              B_TAB)
>                  .GetItem(fSwitchTerminalsMenuItem)
>              .AddItem(B_TRANSLATE("New Terminal"), MENU_NEW_TERM, 'N')

I think the above is one of those situations where B_TRANSLATE_COMMENT or 
maybe even B_TRANSLATE_ALL could be used to pass an additional comment along 
with the translation key into the catalog.

In this case, a comment like "title for menu relating to terminal sessions" 
would IMHO help the translators considerably to keep this translation apart 
from any others keyed by the string "Terminal".

cheers,
        Oliver

Other related posts: