[haiku-commits] Re: haiku: hrev45250 - src/kits/network/libnetapi headers/os/net
- From: Hamish Morrison <hamishm53@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 08 Feb 2013 00:35:00 +0000
On 08/02/2013 00:14, Axel Dörfler wrote:
> Why is this being compiled in unconditionally? Shouldn't it only be part
> of the build if there is no OpenSSL?
There's an #ifdef in md5.c so the functions are only defined if OpenSSL
is not enabled. It might be nicer if it were done in the Jamfile though,
I'll change that.
> I know it's not your code, but: suspiciously little error checking...
> (here and at other places)
Indeed, there's a lot of these robustness issues, and some memory leaks.
I have further changesets yet to merge which deal with these, and the
style issues. Just wanted to break out the changes so they're easier to
manage. :)
Regards,
Hamish
Other related posts:
