[haiku-commits] Re: haiku: hrev45197 - src/servers/app/decorator
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Sat, 26 Jan 2013 22:00:15 -0500
On Jan 26, 2013, at 3:43 PM, Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
wrote:
> On 01/26/2013 1:57 pm, John Scipione wrote:
>> On Fri, Jan 25, 2013 at 12:32 AM, Alexander von Gluck IV
>> <kallisti5@xxxxxxxxxxx> wrote:
>>> On 01/24/2013 11:00 pm, jscipione@xxxxxxxxx wrote:
>>>> hrev45197 adds 1 changeset to branch 'master'
>>>> old head: e5de7e2102c59d0f6464378522d46dab0bb3f5b2
>>>> new head: 3071859cc6842d96fa086771c9463085ea0f2246
>>>> overview:
>>>> http://cgit.haiku-os.org/haiku/log/?qt=range&q=3071859+%5Ee5de7e2
>>> C++
>>> /work/haiku/slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/servers/app/DefaultWindowBehaviour.o
>>> /work/haiku/slave/haiku/src/servers/app/decorator/DefaultWindowBehaviour.cpp:
>>> In member function 'virtual bool
>>> DefaultWindowBehaviour::MouseDown(BMessage*, BPoint, int32, int32&,
>>> int32&)':
>>> /work/haiku/slave/haiku/src/servers/app/decorator/DefaultWindowBehaviour.cpp:847:46:
>>> error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
>>> cc1plus: all warnings being treated as errors
>> Fixed this in hrev45198:
>> 65b9235: Fix gcc4 build by adding parens
>
>
> Sorry.. I sent this right as you committed it.
>
> I moved to a new server and my lack of reverse ptr's was causing
> freelists to ignore my emails :). This came a few days delayed.
Ok I just didn't want you to try and fix it yourself needlessly. I typically
build on gcc2 and it didn't seem to have any problem with the line. Gcc4 is a
bit pickier and so the builds leaves started failing immediately. Nice that we
have them or I wouldn't have known to fix this.
Other related posts:
