[haiku-commits] haiku: hrev43682 - src/kits/mail

  • From: kallisti5@xxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 22 Jan 2012 16:31:47 +0100 (CET)

hrev43682 adds 1 changeset to branch 'master'
old head: fd391ef3c26ca350b10f11fd351003296e60d8ad
new head: 19affa272553f9971e8c5cc52559dd9575b41d71

----------------------------------------------------------------------------

19affa2: mail kit: Use errno vs return codes, gives better results.

                          [ Alexander von Gluck IV <kallisti5@xxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev43682
Commit:      19affa272553f9971e8c5cc52559dd9575b41d71
URL:         http://cgit.haiku-os.org/haiku/commit/?id=19affa2
Author:      Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
Date:        Sun Jan 22 15:31:36 2012 UTC

----------------------------------------------------------------------------

1 files changed, 6 insertions(+), 4 deletions(-)
src/kits/mail/ServerConnection.cpp |   10 ++++++----

----------------------------------------------------------------------------

diff --git a/src/kits/mail/ServerConnection.cpp 
b/src/kits/mail/ServerConnection.cpp
index 819be34..3afdbd8 100644
--- a/src/kits/mail/ServerConnection.cpp
+++ b/src/kits/mail/ServerConnection.cpp
@@ -221,22 +221,24 @@ SocketConnection::Connect(const char* server, uint32 port)
 
        BNetworkAddress address;
        status_t status = address.SetTo(server, port);
-       if (status != B_OK)
+       if (status != B_OK) {
+               TRACE("%s: Address Error: %s\n", __func__, strerror(status));
                return status;
+       }
 
        TRACE("Server resolves to %s\n", address.ToString().String());
 
        fSocket = socket(address.Family(), SOCK_STREAM, 0);
        if (fSocket < 0) {
-               TRACE("%s: Socket Error: %s\n", __func__, strerror(status));
+               TRACE("%s: Socket Error: %s\n", __func__, strerror(errno));
                return errno;
        }
 
        int result = connect(fSocket, address, address.Length());
        if (result < 0) {
-               TRACE("%s: Connect Error: %s\n", __func__, strerror(result));
+               TRACE("%s: Connect Error: %s\n", __func__, strerror(errno));
                close(fSocket);
-               return result;
+               return errno;
        }
 
        TRACE("SocketConnection: connected\n");


Other related posts:

  • » [haiku-commits] haiku: hrev43682 - src/kits/mail - kallisti5