added 1 changeset to branch 'refs/remotes/pdziepak-github/nfs4' old head: 266b99b7e921a71c22ac5d444a107abb282bbf36 new head: a4caa431e4d815581cbd0e71ff0644d2b260d0ec overview: https://github.com/pdziepak/Haiku/compare/266b99b...a4caa43 ---------------------------------------------------------------------------- a4caa43: nfs4: Make sure Request::fNext is initially NULL [ Pawel Dziepak <pdziepak@xxxxxxxxxxx> ] ---------------------------------------------------------------------------- Commit: a4caa431e4d815581cbd0e71ff0644d2b260d0ec Author: Pawel Dziepak <pdziepak@xxxxxxxxxxx> Date: Wed Feb 13 19:21:53 2013 UTC ---------------------------------------------------------------------------- 2 files changed, 7 insertions(+), 3 deletions(-) src/add-ons/kernel/file_systems/nfs4/RPCServer.cpp | 1 + src/add-ons/kernel/file_systems/nfs4/RPCServer.h | 9 ++++++--- ---------------------------------------------------------------------------- diff --git a/src/add-ons/kernel/file_systems/nfs4/RPCServer.cpp b/src/add-ons/kernel/file_systems/nfs4/RPCServer.cpp index 9506af6..811d3d4 100644 --- a/src/add-ons/kernel/file_systems/nfs4/RPCServer.cpp +++ b/src/add-ons/kernel/file_systems/nfs4/RPCServer.cpp @@ -46,6 +46,7 @@ RequestManager::AddRequest(Request* request) else fQueueHead = request; fQueueTail = request; + request->fNext = NULL; } diff --git a/src/add-ons/kernel/file_systems/nfs4/RPCServer.h b/src/add-ons/kernel/file_systems/nfs4/RPCServer.h index 9421049..35c52f8 100644 --- a/src/add-ons/kernel/file_systems/nfs4/RPCServer.h +++ b/src/add-ons/kernel/file_systems/nfs4/RPCServer.h @@ -41,6 +41,9 @@ public: private: mutex fLock; + + // Neither SinglyLinkedList nor DoublyLinkedList is what we want + // here. And DoublyLinkedQueue is not even a queue. Request* fQueueHead; Request* fQueueTail; @@ -72,8 +75,8 @@ public: status_t Repair(); - inline const PeerAddress& ID() const; - inline PeerAddress LocalID() const; + inline const PeerAddress& ID() const; + inline PeerAddress LocalID() const; inline ProgramData* PrivateData(); inline void SetPrivateData(ProgramData* privateData); @@ -94,7 +97,7 @@ private: RequestManager fRequests; Connection* fConnection; - const PeerAddress* fAddress; + const PeerAddress* fAddress; ProgramData* fPrivateData;