[haiku-commits] Re: BRANCH mmadia-github.separate-build-environment - headers/build/config_build headers/build/os_target/support src/build/libroot headers/build/posix_target headers/build/config
- From: Matt Madia <mattmadia@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 5 Aug 2012 14:30:06 +0000
On 8/3/12, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> Matt Madia wrote:
>> On 8/3/12, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
>> > On 2012-08-02 at 22:49:23 [+0200],
>> > mmadia-github.separate-build-environment
>> > <community@xxxxxxxxxxxx> wrote:
>> >> diff --git a/headers/build/posix_target/target_limits.h
>> >> b/headers/build/posix_target/target_limits.h
>> >> index 138fd32..deb1463 100644
>> >> --- a/headers/build/posix_target/target_limits.h
>> >> +++ b/headers/build/posix_target/target_limits.h
>>
>> >> #define _HAIKU_BUILD_LONGLONG_MIN (-9223372036854775807LL - 1) /*
>> >> these are Be specific */
>> >> #define _HAIKU_BUILD_LONGLONG_MAX (9223372036854775807LL)
>> >
>> > Strictly speaking those are compiler specific, though I think long long
>> > is
>> > 64
>> > bit for all platforms/compilers ATM.
>>
>> So, do those need to be changed to #define LONGLONG_MIN?
>
> No. My point was that the values could be incorrect (when long long isn't 64
> bit). Consequently one would have to get them via HaikuHostBuildConfig.h.
Now that the host compiler's limits.h is pulled into
HaikuHostBuildConfig.h, should those values be updated to
_HAIKU_BUILD_FEATURE_LONG_LONG_MIN and
_HAIKU_BUILD_FEATURE_LONG_LONG_MAX respectively?
Attached is HaikuHostBuildConfig.h, from FreeBSD 9
--mmadia
/* auto-generated by configure */
#ifndef _HAIKU_BUILD_HOST_BUILD_CONFIG_H
#define _HAIKU_BUILD_HOST_BUILD_CONFIG_H
#define _HAIKU_BUILD_FEATURE_int8 signed char
#define _HAIKU_BUILD_FEATURE_FORMAT_PREFIX_int8 ""
#define _HAIKU_BUILD_FEATURE_uint8 unsigned char
#define _HAIKU_BUILD_FEATURE_FORMAT_PREFIX_uint8 ""
#define _HAIKU_BUILD_FEATURE_int16 short
#define _HAIKU_BUILD_FEATURE_FORMAT_PREFIX_int16 ""
#define _HAIKU_BUILD_FEATURE_uint16 unsigned short
#define _HAIKU_BUILD_FEATURE_FORMAT_PREFIX_uint16 ""
#define _HAIKU_BUILD_FEATURE_int32 int
#define _HAIKU_BUILD_FEATURE_FORMAT_PREFIX_int32 ""
#define _HAIKU_BUILD_FEATURE_uint32 unsigned int
#define _HAIKU_BUILD_FEATURE_FORMAT_PREFIX_uint32 ""
#define _HAIKU_BUILD_FEATURE_int64 long long
#define _HAIKU_BUILD_FEATURE_FORMAT_PREFIX_int64 "ll"
#define _HAIKU_BUILD_FEATURE_uint64 unsigned long long
#define _HAIKU_BUILD_FEATURE_FORMAT_PREFIX_uint64 "ll"
#define _HAIKU_BUILD_FEATURE___INT_MAX__ 2147483647
#define _HAIKU_BUILD_FEATURE___LONG_LONG_MAX__ 9223372036854775807LL
#define _HAIKU_BUILD_FEATURE___LONG_MAX__ 2147483647L
#define _HAIKU_BUILD_FEATURE__LIMITS_H___ _LIMITS_H___
#define _HAIKU_BUILD_FEATURE__MACH_MACHLIMITS_H_ _MACH_MACHLIMITS_H_
#define _HAIKU_BUILD_FEATURE_CHAR_BIT 8
#define _HAIKU_BUILD_FEATURE_CHAR_MAX 0x7f
#define _HAIKU_BUILD_FEATURE_CHAR_MIN (-0x7f - 1)
#define _HAIKU_BUILD_FEATURE_INT_MAX 0x7fffffff
#define _HAIKU_BUILD_FEATURE_INT_MIN (-0x7fffffff - 1)
#define _HAIKU_BUILD_FEATURE_LLONG_MAX 0x7fffffffffffffffLL
#define _HAIKU_BUILD_FEATURE_LLONG_MIN (-0x7fffffffffffffffLL - 1)
#define _HAIKU_BUILD_FEATURE_LONG_LONG_MAX LONG_LONG_MAX
#define _HAIKU_BUILD_FEATURE_LONG_LONG_MIN LONG_LONG_MIN
#define _HAIKU_BUILD_FEATURE_LONG_MAX 0x7fffffffL
#define _HAIKU_BUILD_FEATURE_LONG_MIN (-0x7fffffffL - 1)
#define _HAIKU_BUILD_FEATURE_MB_LEN_MAX 6
#define _HAIKU_BUILD_FEATURE_SCHAR_MAX 0x7f
#define _HAIKU_BUILD_FEATURE_SCHAR_MIN (-0x7f - 1)
#define _HAIKU_BUILD_FEATURE_SHRT_MAX 0x7fff
#define _HAIKU_BUILD_FEATURE_SHRT_MIN (-0x7fff - 1)
#define _HAIKU_BUILD_FEATURE_UCHAR_MAX 0xff
#define _HAIKU_BUILD_FEATURE_UINT_MAX 0xffffffff
#define _HAIKU_BUILD_FEATURE_ULLONG_MAX 0xffffffffffffffffULL
#define _HAIKU_BUILD_FEATURE_ULONG_LONG_MAX ULONG_LONG_MAX
#define _HAIKU_BUILD_FEATURE_ULONG_MAX 0xffffffffUL
#define _HAIKU_BUILD_FEATURE_USHRT_MAX 0xffff
#endif /* _HAIKU_BUILD_HOST_BUILD_CONFIG_H */
Other related posts:
