[haiku-commits] Re: BRANCH midar-github.master - headers/os/support
- From: Jonathan Schleifer <js-haiku-commits@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 20 Nov 2012 16:42:02 +0100
Am 20.11.2012 um 16:12 schrieb Ingo Weinhold:
> Nicer parameter names please, e.g. Element and kStackArraySize.
Done.
> The brace belongs to the end of the previous line.
Done.
> Private definitions should go to the bottom. Preferred pointer style is "T*".
Both done.
> Rather use size_t.
Oh, size_t is ok? I usually always use size_t and even overuse it (a habit
after 10 years of coding C ;)), but thought that in C++ unsigned long is
preferred, because this seems to be what the STL uses. Changed.
> Return types only go on a separate line when the method is defined
> separately. No space after "operator".
Ok, done.
> That's rather unusual. A method like Array(), Data(), or something like that
> would be more in line with the Haiku API. I'd also vote for an IsValid()
> method as suggested by Stephan.
Should I remove () or add Array() as an addition?
I added IsValid().
--
Jonathan
Other related posts:
