[haiku-bugs] Re: [Haiku] #8670: Improved zoom button behavior
- From: "siarzhuk" <trac@xxxxxxxxxxxx>
- Date: Fri, 06 Sep 2013 14:54:36 -0000
#8670: Improved zoom button behavior
---------------------------------------+----------------------------
Reporter: mmadia | Owner: siarzhuk
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/StyledEdit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking: 8665
Has a Patch: 1 | Platform: All
---------------------------------------+----------------------------
Comment (by siarzhuk):
Hi, ejno1!
Thank you for your contribution!
I have tried your patch and found that window, that was zoomed cannot be
un-zoomed by another click on the same tab icon. You can compare the zoom-
unzoom behavior of the patched StyledEdit with the Terminal for example to
observe the problem.
This functionality is implemented in BWindow::Zoom() and uses the
width/height of the BWindow::fPreviousFrame rect to determine if the
window should be zoomed or unzoomed.
In my opinion it is a good idea to utilize this base functionality and try
to adjust the maxWidth and maxHeight by SetZoomLimits(..) call instead of
direct overriding Zoom(...) virtual. Could you , please, try to improve
your patch in this direction?
PS: BTW, is "ejno1 <none>" the real user info you want to see in Haiku
commit log for your commits? I suspect "<none>" e-mail will be catched by
git hooks as invalid and prevent us to push it. Could you, please provide
a bit more info if possible? Thank you!
--
Ticket URL: <http://dev.haiku-os.org/ticket/8670#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
