[haiku-bugs] Re: [Haiku] #8447: TextView GetText() doesn't straddle the "Gap" properly

  • From: "jackburton" <trac@xxxxxxxxxxxx>
  • Date: Fri, 19 Sep 2014 07:08:31 -0000

#8447: TextView GetText() doesn't straddle the "Gap" properly
----------------------------------+----------------------------
   Reporter:  Pete                |      Owner:  axeld
       Type:  bug                 |     Status:  new
   Priority:  critical            |  Milestone:  R1/alpha5
  Component:  Kits/Interface Kit  |    Version:  R1/Development
 Resolution:                      |   Keywords:
 Blocked By:                      |   Blocking:  11132
Has a Patch:  1                   |   Platform:  All
----------------------------------+----------------------------

Comment (by jackburton):

 Replying to [comment:10 Pete]:
 > Replying to [comment:9 jackburton]:

 > No, because the offset is irrelevant for the second memcpy. The first
 one copies the segment of text from offset up to the gap (pointed to by
 fGapIndex); beforelen is calculated to do this.  The second memcpy has to
 start ''immediately'' after the gap, which is pointed to by fGapIndex +
 fGapCount.  Adding in offset as well would push things too far down.

 Yeah, you're right, indeed.

--
Ticket URL: <https://dev.haiku-os.org/ticket/8447#comment:11>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: