[haiku-bugs] [Haiku] #8306: [PATCH] Allow entire tree to be compiled with DEBUG=2
- From: "umccullough" <trac@xxxxxxxxxxxx>
- Date: Sun, 29 Jan 2012 19:05:07 -0000
#8306: [PATCH] Allow entire tree to be compiled with DEBUG=2
--------------------------+------------------------------
Reporter: umccullough | Owner: bonefish
Type: bug | Status: new
Priority: normal | Milestone: R1/beta1
Component: Build System | Version: R1/Development
Keywords: DEBUG | Blocked By:
Blocking: | Has a Patch: 0
Platform: All |
--------------------------+------------------------------
I decided to try and compile a Haiku image with the following:
{{{
jam -q -sDEBUG=2 -sHAIKU_IMAGE_SIZE=1024 @image
}}}
but ran into a few issues. A couple of broken TRACE() statements have
already been fixed by modeenf, but the remainder are redefinitions of
DEBUG that cause compiler warnings.
It's my opinion that we should not explicitly enable DEBUG 1 in our code,
but it seems there are several places that do that. I think they should be
removed/commented.
However, I have provided some patches that simple check before defining
them instead, just in case these are intentional #defines. The only one I
removed entirely was in the neomagic driver, which is very similar to the
nvidia and matrox drivers in structure - it didn't seem like a good idea
to leave it enabled there.
Comments?
--
Ticket URL: <http://dev.haiku-os.org/ticket/8306>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
