[haiku-bugs] Re: [Haiku] #7445: app_server DecorManager + DecorInfo patch

  • From: "looncraz" <trac@xxxxxxxxxxxx>
  • Date: Wed, 18 May 2011 05:43:12 -0000

#7445: app_server DecorManager + DecorInfo patch
----------------------------------+-------------------------------------
   Reporter:  looncraz            |      Owner:  axeld
       Type:  enhancement         |     Status:  new
   Priority:  normal              |  Milestone:  Unscheduled
  Component:  Servers/app_server  |    Version:  R1/Development
 Resolution:                      |   Keywords:  DecorManager, decorator
 Blocked By:                      |   Blocking:
Has a Patch:  1                   |   Platform:  All
----------------------------------+-------------------------------------

Comment (by looncraz):

 Replying to [comment:10 stargatefan]:
 > I found 1 small typo in the patch although it could have been cuased by
 patch itself. Very simple fix. , the patch works great. also seems to
 lower the ram footprint a tiny bit and makes the ui noticeably snappier on
 a livecd. All it needs is a gui for the decorators and in the preflets and
 its a functional addition to haiku, I am going to install and look for
 regressions but there no reason to stick this patch that far back in the
 cue.

 Thank you for taking a look!

 Funny thing is that the entire time I thought about the patch I was
 thinking from more of a purity stand-point in regards to division of
 responsibilities while wholly overlooking the likelihood of a performance
 increase.

 Makes sense now that I think about it.  No more list look-ups, removed
 several copies during the instantiation process ( just in making the code
 cleaner and more uniform ).

 Let me know if there are any issues, I would like to augment the preview
 capabilities as a separate patch, and maybe I'll take a break from
 LoonCAFE and jump back over to make some modifications to the Appearance
 preflet.

 Thanks again!

 --The loon

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/7445#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: