[haiku-bugs] Re: [Haiku] #6353: Trying to download 3gp file crashes appserver

  • From: "stimut" <trac@xxxxxxxxxxxx>
  • Date: Mon, 10 Jan 2011 09:06:52 -0000

#6353: Trying to download 3gp file crashes appserver
---------------------------------+------------------------------
  Reporter:  pulkomandy          |        Owner:  stippi
      Type:  bug                 |       Status:  new
  Priority:  normal              |    Milestone:  R1
 Component:  Servers/app_server  |      Version:  R1/Development
Resolution:                      |     Keywords:
Blocked By:                      |  Has a Patch:  0
  Platform:  All                 |     Blocking:
---------------------------------+------------------------------
Changes (by stimut):

 * component:  Applications/WebPositive => Servers/app_server


Comment:

 In ServerWindow::_DispatchViewDrawingMessage(), in the case for
 AS_DRAW_STRING_WITH_OFFSETS, on line 2785, the string length rather than
 the number of UTF8 glyphs is used. This would often be OK except when
 printing funky characters like in the linked .3gp file above. Since some
 of the characters will be multibyte, the string length will be longer than
 the number of glyhs, which means we call ConvertToScreenForDrawing with
 values beyond the end of the locations array, causing the access violation
 and the crash.

 It is only a simple one line fix, which I have attached.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6353#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: