#6257: Implement basic archiving for BLayout and BLayoutItem classes. ---------------------------------+------------------------------------------ Reporter: yourpalal | Owner: pulkomandy Type: enhancement | Status: assigned Priority: normal | Milestone: R1 Component: Kits/Interface Kit | Version: R1/Development Resolution: | Keywords: Blocked By: 6256 | Has a Patch: 1 Platform: All | Blocking: 5525 ---------------------------------+------------------------------------------ Changes (by pulkomandy): * owner: axeld => pulkomandy * status: new => assigned Comment: As Ingo is reviewing the other patch, I'll have a look at this one. * Layout.cpp line 17: what is this anonymous namespace for ? To hide things from the API users, you should use the BPrivate namespace. And I'm not sure it's useful here. line 39: a while loop would be more readable here, I think. Many places in the code: 2 blank lines between blocks. This include the anonymous namespace in layoutitem.cpp, and most of the methods you added. The comment stating the method name isn't really usefull, either. Otherwise, the patch looks fine. I'm waiting for the blocking one to be commited first, obviously. -- Ticket URL: <http://dev.haiku-os.org/ticket/6257#comment:3> Haiku <http://dev.haiku-os.org> Haiku - the operating system.