[haiku-bugs] Re: [Haiku] #6115: Extension of the USB HID Usages
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Tue, 01 Jun 2010 20:13:28 -0000
#6115: Extension of the USB HID Usages
-------------------------+--------------------------------------------------
Reporter: x-ist | Owner: mmlr
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: - General | Version: R1/alpha2
Keywords: usb_hid.h | Platform: All
Blockedby: | Patch: 1
Blocking: |
-------------------------+--------------------------------------------------
Changes (by axeld):
* owner: nobody => mmlr
* status: new => assigned
Comment:
Thanks for your work!
Just a few remarks:
* The changes of the HID usage IDs probably require an updated HID
driver?
* No blank line between the copyright header, and the header guard.
* The references and other comments do not belong into the copyright
header.
* We usually don't add authors to public headers; they specify the system
API, and even though someone actually took the time to wrote it, everyone
needs to be okay with them - it's your call in the end, though.
* Two blank lines between sections, ie. after the header guard, and
before the last #endif.
* If those should really be public headers, we should add the B_ prefix
to all constants.
* I find the header names a bit odd: why is hid_page lower case and
Keyboard upper case? I would prefer lower case (with an extra _ for
alphanumeric_display)
* In general, the constant names look good IMO.
Maybe mmlr has some other comments, as he is more into the subject.
--
Ticket URL: <http://dev.haiku-os.org/ticket/6115#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
