[haiku-bugs] Re: [Haiku] #5690: Filetypes: use Layout API
- From: "yourpalal" <trac@xxxxxxxxxxxx>
- Date: Fri, 16 Apr 2010 04:20:34 -0000
#5690: Filetypes: use Layout API
-----------------------------------+----------------------------------------
Reporter: yourpalal | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Preferences/FileTypes | Version: R1/alpha1
Keywords: gsoc2010 | Blockedby:
Platform: All | Blocking:
-----------------------------------+----------------------------------------
Comment(by yourpalal):
Okay, there we are, I think that should do it, I've fixed the style
violations (that I could find with the python tool), the modification vs.
invocation message, the SetEnabled(), (I forgot to do
ApplicationTypesWindow.cpp, but I've fixed that) I also did another window
which I had missed the first time, and reviewed the patch, and it seems to
be good. I've played around with the updated version next to the non-
layout version and they seem to behave about the same. The one question I
have is about be_control_look->GetDefaultItemSpacing(), which seems to
return very large values, is it expected for an app to divide that number
for certain uses? For the mean time, I've commented out the code that uses
that data. Hopefully this patch looks good!
--Alex
--
Ticket URL: <http://dev.haiku-os.org/ticket/5690#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
