[haiku-bugs] Re: [Haiku] #5479: [patch] More support for *.tgz
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Fri, 26 Feb 2010 13:09:44 -0000
#5479: [patch] More support for *.tgz
--------------------------+-------------------------------------------------
Reporter: mmadia | Owner: bonefish
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Build System | Version: R1/Development
Keywords: | Blockedby:
Platform: All | Blocking: 5455
--------------------------+-------------------------------------------------
Comment(by bonefish):
Looks good. A few remarks:
- DownloadOptionalPackage still contains some commented out code,
probably from experimenting. Since the rule has become an alias of
DownloadFile and is used only in one instance, I'd just remove it.
- CreateContainerExtractFilesScript: I suppose the note is mostly
obsolete and at least the commented out code should be removed. Have you
checked out the sh vs. bash question?
- Regarding code duplication in build_haiku_image, build_haiku_cd, and
probably other scripts, that's indeed annoying. It would be nice to unify
the scripts again or at least move commonly used code to a sourceable
helper script. That's material for a separate undertaking, though.
- No need to pass "tar" to the script at all. As long as we don't add
Haiku-specific extensions (like attribute support), using the build
platform's tar in the script is just fine.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5479#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
