[haiku-bugs] Re: [Haiku] #4930: Keyboard navigating context menu

  • From: "Ziusudra" <trac@xxxxxxxxxxxx>
  • Date: Wed, 30 Jun 2010 22:27:01 -0000

#4930: Keyboard navigating context menu
--------------------------------+-------------------------------------------
 Reporter:  humdinger           |       Owner:  axeld    
     Type:  bug                 |      Status:  new      
 Priority:  normal              |   Milestone:  R1       
Component:  Kits/Interface Kit  |     Version:  R1/alpha2
 Keywords:                      |   Blockedby:           
    Patch:  1                   |    Platform:  All      
 Blocking:                      |  
--------------------------------+-------------------------------------------

Comment(by Ziusudra):

 The latest change looks good.

 One more thing, AttachedToWindow() should set fAttachAborted true when
 _AddDynamicItems() returns true. Otherwise, _Show() will always act as if
 the attach succeeded.

 Personally, I would rename the attachAborted locals to addAborted as it
 more clearly reflects their purpose, but that's not important.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/4930#comment:24>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: