[haiku-bugs] Re: [Haiku] #4463: Add multi-ports support to USB MIDI driver
- From: "Pete" <trac@xxxxxxxxxxxx>
- Date: Sat, 19 Feb 2011 06:09:46 -0000
#4463: Add multi-ports support to USB MIDI driver
--------------------------+------------------------------
Reporter: Pete | Owner: phoudoin
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Drivers/USB | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
--------------------------+------------------------------
Comment (by Pete):
Replying to [comment:17 korli]:
> I noticed a few style issues in the patch:
> * DPRINTF_INFO(("Interface count = %ld\n", conf->interface_count);) =>
; is misplaced.
Just a point of curiosity -- ''why'' do you consider it "misplaced"? (:-/)
Don't see anything about it in the guidelines.
That's the way I've always done it with such 'elidable' macros. With that
convention inactive macros completely disappear, not even leaving an
empty-statement semicolon. The only hazard is if it's the sole statement
in a conditional, but I've always added braces in a situation like that
for clarity anyway.
It's no big deal, and I've changed all my added printouts to conform to
the older ones, but I'd be interested to know if there is some strong
reason for terminating with "));"
--
Ticket URL: <http://dev.haiku-os.org/ticket/4463#comment:25>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
