[haiku-bugs] Re: [Haiku] #4339: Screen saver settings are lost when switching tabs

  • From: "stimut" <trac@xxxxxxxxxxxx>
  • Date: Wed, 20 Jan 2010 06:56:23 -0000

#4339: Screen saver settings are lost when switching tabs
-------------------------------------+--------------------------------------
 Reporter:  VinDuv                   |       Owner:  axeld        
     Type:  bug                      |      Status:  new          
 Priority:  normal                   |   Milestone:  R1           
Component:  Preferences/ScreenSaver  |     Version:  R1/pre-alpha1
 Keywords:                           |   Blockedby:               
 Platform:  All                      |    Blocking:               
-------------------------------------+--------------------------------------
Changes (by stimut):

 * cc: stimut@… (added)


Comment:

 This seems to be because the settings panel is actually generated by the
 screen saver itself (and not the ScreenSaver preflet), so we can't hook
 into any of the messages that would be caused when a setting is changed.

 I have therefore created a patch which uses the
 ModulesView::DetachedFromWindow() function to save the settings. This
 caused a crash when quitting from the modules view though (presumably
 because the settings object has already been deleted by the time the
 DetachedFromWindow() function is called), so I had to add a variable which
 is set in QuitRequested() so that we don't try and save in
 DetachedFromWindow() when we are quitting (the settings are already saved
 in QuitRequested()).

 It doesn't feel like the cleanest solution to me, but I couldn't think of
 another way.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/4339#comment:1>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: