[haiku-bugs] Re: [Haiku] #3762: PackageInstaller and handling script files

#3762: PackageInstaller and handling script files
-------------------------------------------+--------------------------------
 Reporter:  sil2100                        |       Owner:  sil2100      
     Type:  bug                            |      Status:  in-progress  
 Priority:  low                            |   Milestone:  Unscheduled  
Component:  Applications/PackageInstaller  |     Version:  R1/pre-alpha1
 Keywords:                                 |   Blockedby:               
 Platform:  All                            |    Blocking:               
-------------------------------------------+--------------------------------

Comment(by sil2100):

 Thanks for reviewing the patch, korli!

 I have fixed the bugs you have highlighted in the new patch attached
 below. I have added the deletion of *script memory in _ParseScript(),
 although it was not really necessary - the memory allocated in *scipt
 during _ParseScript() was later freed in the DoInstall() method (if, of
 course, the inflate_data function failed). But your approach seems more
 consistent in this case.

 I am also sorry for the style problems - I am trying to proof read the
 code before submition, but it's really hard to get rid of some coding
 habits.
 Hope I did not miss anything.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/3762#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: