[haiku-bugs] Re: [Haiku] #1944: Kill command don't work with process names

  • From: "leavengood" <trac@xxxxxxxxxxxx>
  • Date: Wed, 06 Mar 2013 17:15:06 -0000

#1944: Kill command don't work with process names
-----------------------------------------------+---------------------------
   Reporter:  tqh                              |      Owner:  leavengood
       Type:  bug                              |     Status:  assigned
   Priority:  normal                           |  Milestone:  R1
  Component:  Applications/Command Line Tools  |    Version:
 Resolution:                                   |  R1/Development
 Blocked By:                                   |   Keywords:
Has a Patch:  1                                |   Blocking:  4687, 8162
                                               |   Platform:  All
-----------------------------------------------+---------------------------
Changes (by leavengood):

 * owner:  axeld => leavengood
 * status:  new => assigned


Comment:

 +1 to this patch, with the exception that some of the variable names in
 the new functions in kill are too short (e and n in is_number(), and tm,
 tc, p and q in kill_by_name().) In addition the "int  l" in kill_by_name
 is not used, as far as I can see.

 Overall, very nice patch Prasad! If Prasad is around and willing to fix
 the variable names, please do. Otherwise I'll apply this patch and fix the
 variable names myself before the end of the week.

--
Ticket URL: <http://dev.haiku-os.org/ticket/1944#comment:26>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: