[haiku-bugs] Re: [Haiku] #12365: password generation must be more secured

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Mon, 16 Jan 2017 21:37:38 -0000

#12365: password generation must be more secured
---------------------------+---------------------------------------
   Reporter:  eanyx        |      Owner:  nobody
       Type:  enhancement  |     Status:  new
   Priority:  critical     |  Milestone:  Unscheduled
  Component:  System       |    Version:  R1/Development
 Resolution:               |   Keywords:  hash password /etc/shadow
 Blocked By:               |   Blocking:
Has a Patch:  1            |   Platform:  All
---------------------------+---------------------------------------

Comment (by axeld):

 Great, thanks! Since 'NLog2' is a variable, it should start with lower-
 case 'n' -- for constants, the UPPER_CASE_STYLE is tolerable, although
 kConstant is preferred; so using 'N' there is okay. But I also wouldn't
 mind to lose the `const` and call it 'n' to make the two combine better
 :-)

 You've introduced a number of new coding style violations in the tests
 (most notably in LibRootPosix.cpp), but I'd be okay with committing it as
 is as part of the tests, if you're okay with that.

--
Ticket URL: <https://dev.haiku-os.org/ticket/12365#comment:12>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: