[dokuwiki] Re: git changes 2010-12-09
- From: Robin Getz <robin.getz@xxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Thu, 16 Dec 2010 14:09:03 -0500
On Mon 13 Dec 2010 16:35, Andreas Gohr pondered:
> >> > + $addr = explode(':',$_SERVER['SERVER_NAME']);
> >>
> >> No this doesn't change anything.
> > Sure it does - it has the same:
> > + if(!$host) $host = 'example.com';
> > in it that yours did.
>
> It doesn't change anything from my patch ;-)
Right - It just does it in a different place. (higher up in the stack)
> > Right - so are we better off fixing the DOKU_URL so that it is parsable?
> >
> > in inc/init.php:getBaseURL() which should make
> > sure that DOKU_URL is OK?
>
> I believe ./ is the best guess we can take. There isn't really a way
> to construct the real URL without the HTTP environment. And we don't
> really have any problem here since we don't even use the mail system
> from the command line, it just gets initialised in inc/init.php and
> threw a warning. Even if you'd use the mail system you only have a
> problem when you're using replacement patterns in your from address.
I grok that - the point I was trying to make is that in the future, in a
different subsystem (not mail), may run into the same issue. Better to make a
general fix - isn't it?
Your fix is for Mail (where the problem exists today)
My suggestion changes mail, and anything else that may use it in the future.
-Robin
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
