[dokuwiki] New PR: fix remaining failing tests for PHP 8
- From: "micgro42" <wiki@xxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Sat, 20 Feb 2021 15:53:06 +0100 (CET)
Hi,
micgro42 opened a new pull request at
https://github.com/splitbrain/dokuwiki/pull/3412:
This fixes the last two failing tests in #3404
@splitbrain
[wrote](https://github.com/splitbrain/dokuwiki/pull/3404#issuecomment-780158632):
Only two issues remaining
parserutils_set_metadata_during_rendering_test::test_p_set_metadata_during_rendering
Undefined array key 2
Here I'd say fixing the test to match "normal" instructions is the way to go
remoteapicore_test::test_getBacklinks
Failed asserting that false is true.
Not sure why this one is failing, yet.
The failure of those two tests was actually connected. Fixing the error
resolves the failure.
I recommend reviewing this PR commit-by-commit.
Please help us to review this pull request, so new contributors get feedback in
a timely manner.
567f3e00-738b-11eb-9b81-e53b56a8a532
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
- » [dokuwiki] New PR: fix remaining failing tests for PHP 8 - micgro42
