[dokuwiki] Re: MEDIA_FILE_MISSING event
- From: Andreas Gohr <andi@xxxxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Tue, 23 Feb 2010 22:28:21 +0100
> Ok. I made a patch which works four our setup. Can you please check if it
> fits the needs and style of DW?
I applied your patch, then made a few changes. We talked on IRC about
only firing the event for errors. After having a look at your patch
and thinking about it again, I changed my mind. It now fires for all
status codes. This makes it possible to intercept redirects or adding
your own additional status checks.
Two notes on the coding style: function comments need to start with
/** (two asterisks on the first comment line) and please stick to
spaces not tabs. Please also try to avoid trailing whitespaces.
Good work. I'm looking forward to your next patches :-)
Can you please document the event at dokuwiki.org?
Andi
--
splitbrain.org
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
