[dokuwiki] Re: Bad case of spamming + changelog code


On Oct 17, 2006, at 1:46 AM, Andreas Gohr wrote:

On Mon, 16 Oct 2006 22:47:32 -0700
Ben Coburn <btcoburn@xxxxxxxxxxxxx> wrote:


On Oct 16, 2006, at 6:28 PM, Andreas Gohr wrote:

It can happen, that there is no changelog entry for an old revision.
I'm not sure how this happens but for some spams there was no old
revision available. The file in the attic got created but there was
no matching entry in the attic (or get_revisions did not find it).
We need to investigate this.


This is not clear. Which part are you saying is missing? 

Currently only old revisions are shown when a changelog entry exists.
This may not be always the case. To reproduce:

1. create a text file in data/pages
2. View the according page in the wiki
3. Edit the page through the wiki
4. Go to Old revisions and try to revert to the old revision ;-)

I guess the solution is to merge the changelog info with the list of
matching attic files. I will have a look at this.


I believe the correct way to create or edit pages manually is to use the 'bin/dwpage.php' commit (or checkout, edit, and commit) the page. This will keep the changelog, attic, metadata, and lock files in sync. So, step 1 should be a dwpage commit.

Scanning the attic on every call to getRevisions is inefficient. This was one of the things that I removed when optimizing the changelog.

One note, dwpage.php needs to set the correct ownership or relax the permissions of the files (and directories) it creates. When I tried this with dwpage it created files that the web server could not edit/delete!

Regards, Ben Coburn


-------------------
  silicodon.net
-------------------

--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: