[codeface] Re: [PATCH 00/12] Feature-aware Collaboration Analysis with Codeface (after first Review)
- From: Matthias Dittrich <matthi.d@xxxxxxxxxxxxxx>
- To: codeface@xxxxxxxxxxxxx
- Date: Thu, 20 Nov 2014 13:36:20 +0100
Hi,
On 19.11.2014 21:40, Matthias Dittrich wrote:
These are the reworked patches after the initial review.
I also introduced some new changes and refactorings and added some more changes
I did in the meantime.
The review-tag was only added for patches that were actually reviewed.
I hope I managed to address all your points.
Matthias Dittrich (12):
Upgrade to latest nodejs changes.
Changes to make the files better standalone executable within pydev
IDE (especially unit tests).
Fix of some typos in code comments.
Fixed typo bugs in code (noticed by pycharm).
Add a _get_feature_lines function which calculates feature sets for
all source code lines.
Add unit tests for the get_feature_lines functions.
Added some functions to calculate the collaboration between developers
with feature instead of function blocks.
Integrate feature analysis by providing a CLI parameter.
Fixed some undefined variable errors.
Fix for LinkType.file.
Trace features and functions in the collaboration analysis.
Fill the commit_dependency table on a feature analysis pass.
README.md | 27 +-
codeface/VCS.py | 250 ++++++++++-
codeface/cli.py | 15 +-
codeface/cluster/PersonInfo.py | 80 +++-
codeface/cluster/cluster.py | 503 ++++++++++++++++++++--
codeface/cluster/codeBlock.py | 11 +-
codeface/fileCommit.py | 81 +++-
codeface/linktype.py | 29 ++
codeface/project.py | 20 +-
codeface/test/integration/test_exampleprojects.py | 6 +-
codeface/test/unit/test_getFeatureLines.py | 222 ++++++++++
codeface/util.py | 22 +
id_service/id_service.js | 7 +-
13 files changed, 1207 insertions(+), 66 deletions(-)
create mode 100644 codeface/linktype.py
create mode 100644 codeface/test/unit/test_getFeatureLines.py
I fixed some additional white space and integration issues (especially
Patch 08/12).
Because I'm now using the tagging configuration instead of my own
--collaboration parameter there were some missing pieces...
But I'm not sure if it is worth sending the complete patch-list again.
Do you think I should send all patches again or just patch 08 (or nothing)?
I'm asking because I don't want to start spamming the list with the same
patches.
On github all patches are up2date
(https://github.com/siemens/codeface/pull/9).
Kind regards, Matthias
Other related posts:
