---------- Forwarded message ---------- From: WALTER LITWINCZYK (RIT Student) <wtl4112@xxxxxxx> Date: Sat, Apr 28, 2012 at 10:34 PM Subject: Re: -Werror pains To: David Larsen <dcl9934@xxxxxxx> Or we can turn off certain errors like: -Wno-unused-variable There's a counter -Wno- for every error We could also have a secondary build target that turns -Werror on, so when we're done we just run that once before committing On Sat, Apr 28, 2012 at 10:27 PM, David Larsen <dcl9934@xxxxxxx> wrote: > On 4/28/12 6:28 PM, WALTER LITWINCZYK (RIT Student) wrote: > >> [...] I will note -Werror does make it difficult to do >> code->compile->test->repeat, but it's definitely better to have on than off >> > > Sean and I have mixed feelings about this as well. There's been plenty of > "YES, I know that variable's unused, I just haven't gotten around to it!" > On the other hand, things such as passing a 'struct foo*' to a function > that expects a 'struct bar*' is only considered worth a warning, while I > think it definitely deserves an error. > > For the specific case of unused variables (whose warnings are generated by > -Wextra) we could make a way to disable -Wextra or -Werror with options to > make (e.g. make WERROR=false WEXTRA=false) with the default being to enable > them. Do you think that this would help? > > > -David >