[vitunes] Re: Socket stuff (was: mailling list problems ?)
- From: kilian <kilian.klimek@xxxxxxxxxxxxxx>
- To: vitunes@xxxxxxxxxxxxx
- Date: Thu, 24 Feb 2011 11:16:17 +0100
Hi,
On Thu, Feb 24, 2011 at 01:16:42AM -0500, Ryan Flannery wrote:
> Hi list,
>
> > ps: Ryan, there in a pull request for you on github.
>
> Received and merged! I quite like. Works fine on OpenBSD.
>
> Can anyone test on OS X?
>
> Two comments/questions:
>
> 1. If we fail to open the socket, is exitting reasonable? That seems
> a bit heavy.
>
> 2. If vitunes has a socket, and exits unexpectedly
> (segfault/SIGKILL/etc), the socket still exists. Easy thoughts around
> this? A lock/pid file perhaps?
>
> -ryan
>
2: This is already taken care of. In sock_listen, the socket file is
deleted first (because if it exists, the bind call would fail).
1: There are very few reasons why that can fail. My reasoning was that
if it fails (e.g. because the socket file exists and can't be deleted by
us), a vitunes user needs _some_ feedback about what is going on.
Displaying a message in the bottom bar is IMHO not an option because
that might shadow other errors. So, it's far from ideal but it was the
best option.
Using perror(3) / strerror(3) to produce a better error message would
have been good though.
Any other ideas how to handle this?
-kilian
Other related posts:
