[TextEditor_mcc] Re: Welcome!

  • From: Jens Langner <Jens.Langner@xxxxxxxxxxxxxx>
  • To: texteditor_mcc@xxxxxxxxxxxxx
  • Date: Fri, 08 Apr 2005 02:07:45 +0200

Hello Ilkka,

On Thu, 07 Apr 2005 23:28:22 +0300, Ilkka Lehtoranta wrote:

>> So here's the mailing list. I have subscribed Jens, Sebastian, Gunther
>> and Ilkka. If anyone can provide me with a suitable address for Allan,
>> I'll be glad to bring him as well.
>> As usual the list is "closed subscription" (all subscriptions require
>> moderator approval) and it won't accept mail from non subscribed
>> addresses. Any other developers who should be here, or if you have any
>> problem with the list, please let me know.
> Okay. Thanks! :)
> And first problems.
> I found out that MCP module is not working in MorphOS and found out 
> dispathcers are not trapped.
> I.e. in mcp/library.c in line 75 I changed MUI_CreateCustomClass() to
> this:
>     if((widthslider_mcc = MUI_CreateCustomClass(NULL, "Slider.mui",
>     NULL, 0, ENTRY(WidthSlider_Dispatcher))))
> But this gives me an error because Gate_WithSlider_Dispatcher is
> undefined  and it is indeed is because it is in Dispatcher.c and gate
> is static.
> Proposals how to do this cleanly?

Whoops. I knew I missed something with that Dispatcher stuff back when I
prepared the sources for LGPL release. Thanks for the hint.
Please have a look at the Dispatcher.c file now where I have put explicit
Create/Delete function to generate/cleanup the subclasses stuff. That should
hopefully solve the MorphOS problem. Please give it a spin.

> Another problem arises with mcc/ExportHook.c:
> ExportHook.c:299: parse error before `}'
> ExportHook.c:299: redefinition of `Gate_ExportHookFunc'
> ExportHook.c:298: `Gate_ExportHookFunc' previously defined here
> I looked into SDI_hook.h and I think it could be simpler if HookEntry
> was  used instead of traps? It would work on 68k too on any compiler.
> In fact  most of compiler or system specific stuff could be removed if
> HookEntry  was used? But right now ExportHook.c wont compile on MorphOS
> and with  current trap approach it never will.

Hmm. I have to admit that I am not completly uptodate with how MorphOS is
dealing with that all today. Back when I wrote SDI_hook.h together with Dirk
Stoecker it was more or less the only way to do that.
But please feel free to propose a change here. What exactly would you change
in SDI_hook.h? Please show some examples prior to changing SDI_hook.h

Until that, I would better propose to revert the MakeHookWithData() stuff
Sebastian changed in SDI_hook.h. I guess he just missed that this
MakeHook()/MakeStaticHook() are only allowed directly after the closing
braces after a HOOKPROTO() definition. The current scheme doesn't allow to
have two MakeHook() followed each other.

So, either we revert the stuff or we copy&paste the export hooks and make
two out of them with removing the TRUE/FALSE h_Data alteration. Perhaps
probably that would be even better than reverting sebastian's change as we
would anyway change the ExportHook sooner or later.


Jens Langner                                               Ph: +49-351-4716545
Lannerstrasse 1
01219 Dresden                                      Jens.Langner@xxxxxxxxxxxxxx
Germany                                            http://www.jens-langner.de/

Wenn eine Frau nicht spricht soll man sie um Himmels willen nicht unterbrechen
-- Enriyeu Castaldo

TextEditor ML   - http://www.freelists.org/list/texteditor_mcc
Listserver help - mailto:texteditor_mcc-request@xxxxxxxxxxxxx?Subject=HELP
Bugtracker......: http://sourceforge.net/tracker/?atid=731469&group_id=135025

Other related posts: