Re: [PATCH] xen: introduce privcmd device

  • From: Wei Liu <wei.liu2@xxxxxxxxxx>
  • To: Antti Kantee <pooka@xxxxxx>
  • Date: Tue, 23 Jun 2015 11:40:01 +0100

On Mon, Jun 22, 2015 at 09:05:50PM +0000, Antti Kantee wrote:

Oh, one thing popped into mind that I remember paying attention to when
initially reading over the patch but then forgetting to comment on it.

On 22/06/15 13:16, Wei Liu wrote:
diff --git a/platform/xen/xen/hypervisor.c b/platform/xen/xen/hypervisor.c
index e4d8bbd..bf643d7 100644
--- a/platform/xen/xen/hypervisor.c
+++ b/platform/xen/xen/hypervisor.c
@@ -120,3 +120,22 @@ inline void minios_clear_evtchn(uint32_t port)
shared_info_t *s = HYPERVISOR_shared_info;
synch_clear_bit(port, &s->evtchn_pending[0]);
}
+
+inline int minios_hypercall(unsigned op, unsigned long a0,
+ unsigned long a1, unsigned long a2,
+ unsigned long a3, unsigned long a4)
+{
+ multicall_entry_t call;
+ int ret;

Why inline? Pasto?

Inline removed.

Wei.

Other related posts: