[procps] Re: procps-ng 3.3.17 released
- From: Adam Sampson <ats@xxxxxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Tue, 09 Feb 2021 12:52:28 +0000
Craig Small <csmall@xxxxxxxxxxxx> writes:
The procps-ng developers are pleased to announce that version 3.3.17
was released today.
While packaging this, I've found a couple of problems with this release:
- The directory name inside the tarball doesn't match the tarball name:
it's called procps-3.3.17, rather than procps-ng-3.3.17. Many
packaging tools will expect these to be the same (as they were in
previous releases).
- The test suite fails -- when pkill is invoked by the testsuite, the
binary name is something like "lt-pkill", and the new code added for
pwait doesn't handle this. So the pkill tests can't work as written.
The old version of the code used strstr rather than strcmp to compare
the names; I've attached a patch to make the new code do the same.
Fix test suite failures owing to unrecognised lt- executable names.
This restores the behaviour from procps-3.3.16.
--- procps-3.3.17/pgrep.c 2021-02-09 10:11:25.000000000 +0000
+++ procps-3.3.17/pgrep.c 2021-02-09 12:46:45.406245477 +0000
@@ -794,12 +794,12 @@
};
#ifdef ENABLE_PWAIT
- if (strcmp (program_invocation_short_name, "pwait") == 0) {
+ if (strstr (program_invocation_short_name, "pwait")) {
prog_mode = PWAIT;
strcat (opts, "e");
} else
#endif
- if (strcmp (program_invocation_short_name, "pkill") == 0) {
+ if (strstr (program_invocation_short_name, "pkill")) {
int sig;
prog_mode = PKILL;
sig = signal_option(&argc, argv);
Thanks,
--
Adam Sampson <ats@xxxxxxxxx> <
http://offog.org/>
Other related posts:
