[pisa-src] r1348 - trunk/libpisa/config.c

  • From: Thomas Jansen <mithi@xxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Tue, 27 Oct 2009 16:51:53 +0100

Author: tjansen
Date: Tue Oct 27 16:51:53 2009
New Revision: 1348

Log:
Added a TODO comment to make libpisa reentrant at some point.

Modified:
   trunk/libpisa/config.c

Modified: trunk/libpisa/config.c
==============================================================================
--- trunk/libpisa/config.c      Tue Oct 27 16:46:55 2009        (r1347)
+++ trunk/libpisa/config.c      Tue Oct 27 16:51:53 2009        (r1348)
@@ -18,6 +18,11 @@
 #include "debug.h"
 #include "util.h"
 
+/* TODO: global variables are ugly. Without pisa_ prefix they are really ugly.
+ * This is a classic way to break a library that aims to be reentrant, too.
+ * Think up a clever way to get rid of those variables or at least encapsulate
+ * them with a init()/deinit() kind of construct.
+ * --Thomas */
 config_t cfg;
 config_t authorized_cfg;
 char authorized_cfg_file[MAX_PATH+1];

Other related posts:

  • » [pisa-src] r1348 - trunk/libpisa/config.c - Thomas Jansen