[pisa-src] Re: r1295 - in trunk/community-operator: pisa_cert.c pisa_cert.h

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Thu, 22 Oct 2009 17:55:48 +0200

On Thu, Oct 22, 2009 at 05:52:13PM +0200, Jan Marten wrote:
> 
> Log:
> Added missing files pisa_cert.c pisa_cert.h
> 
> --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> +++ trunk/community-operator/pisa_cert.c      Thu Oct 22 17:52:13 2009        
> (r1295)
> @@ -0,0 +1,165 @@
> +/** @file
> + * This file deals with the PISA specific handling of SPKI certificates. The
> + * certificate is parsed and split into small chunks.
> + *
> + * @author Thomas Jansen
> + */

This should now use our copyright boilerplate.

> --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> +++ trunk/community-operator/pisa_cert.h      Thu Oct 22 17:52:13 2009        
> (r1295)
> @@ -0,0 +1,30 @@
> +/** @file
> + * A header file for pisa_cert.c.

No comment is better than a useless comment :)

> + *
> + * @author Thomas Jansen
> + */

This should now use our copyright boilerplate.

> +#ifndef HIP_PISA_CERT_H
> +#define HIP_PISA_CERT_H

The HIP_ prefix is wrong, it should now be PISA_.

> +#endif

This should have an #endif comment.

Diego

Other related posts: