[pisa-src] Re: r1294 - in trunk/community-operator: Makefile.am co_client.c

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Thu, 22 Oct 2009 18:22:49 +0200

On Thu, Oct 22, 2009 at 05:48:20PM +0200, Jan Marten wrote:
> 
> Log:
> Copied pisa_cert.c and pisa_cert.h from HIPL source to remove the linking 
> from the Makefile
> 
> --- trunk/community-operator/Makefile.am      Thu Oct 22 17:47:23 2009        
> (r1293)
> +++ trunk/community-operator/Makefile.am      Thu Oct 22 17:48:20 2009        
> (r1294)
> @@ -20,23 +20,17 @@
>  INCLUDES += -I@PISA_HIPL_SRCDIR@/pjproject/pjlib/include
>  INCLUDES += -I@PISA_HIPL_SRCDIR@/pjproject/pjlib-util/include
> +endif
>  
>  co_server_LDADD  = @PISA_HIPL_SRCDIR@/libinet6/.libs/libinet6.a
>  co_server_LDADD += @PISA_HIPL_SRCDIR@/libhiptool/.libs/libhiptool.a
>  
> -# TODO correct linking
> -# pisa_split_cert function is needed in co_client.c
> -# Do not know any better way so far.
> -  co_client_LDADD = @PISA_HIPL_SRCDIR@/firewall/pisa_cert.o
> -endif

This 'endif' was there for a reason.  The HIPL libs need not exist if
you haven't configured your tree for HIPL support.  This breaks
compilation in that case!

rice_cakes++;

Diego

Other related posts: