[pisa-src] Re: r1135 - trunk/include/util.h

  • From: Diego Biurrun <diego@xxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Wed, 14 Oct 2009 11:23:13 +0200

On Wed, Oct 14, 2009 at 11:09:27AM +0200, Thomas Jansen wrote:
> On Wed, Oct 14, 2009 at 11:02:05AM +0200, Diego Biurrun wrote:
> > You nicely described the warning, but the best description is to simply
> > paste it into the log message.  That's quicker and more precise than
> > describing it.  Imagine that a file produced several similar warnings (a
> > fact that is not unheard of).  Then it would not be clear which one you
> > actually did fix.
> 
> Nice point. Forgive me for not reading your mail before the next commit.

Forgiven ;-p

> I'll keep it in mind from now on. Unfortunately, I've fixed all warnings
> by now. ;)

If you feel the urge, fix the commit messages.  If not, just let it
go...

Diego

Other related posts: